This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
docs(envoy): Document ports used by envoy #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
michelleN
approved these changes
Mar 12, 2021
nojnhuh
approved these changes
Mar 12, 2021
draychev
reviewed
Mar 12, 2021
|
|
||
| ## Ports | ||
| Do not use the following ports as they are used by the Envoy sidecar. |
There was a problem hiding this comment.
Suggested change
| Do not use the following ports as they are used by the Envoy sidecar. | |
| The following ports are used by the Envoy sidecar. |
There was a problem hiding this comment.
@draychev, I don't agree with the suggested wording, it is rather ambiguous when this section of the doc needs to be explicit.
draychev
approved these changes
Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kalya Subramanian kasubra@microsoft.com
Description:
Documents ports used by Envoy so that customers know not to use them for their applications.
Closes #2106
Affected area:
Please answer the following questions with yes/no.